Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create post with tags from the UI #1240

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MercierMateo
Copy link
Contributor

@MercierMateo MercierMateo commented Jan 12, 2025

Issue: #1211

Follow up on this closed PR : #1221

Visitors can now create post with tags from the ui

@MercierMateo
Copy link
Contributor Author

I achieved a first working version. I will look into making this optional through the configuration.

@mattwoberts mattwoberts marked this pull request as ready for review January 18, 2025 20:32
Comment on lines +78 to +84
navigator.replaceState(
querystring.stringify({
view: querystring.get("view"),
query: querystring.get("query"),
tags: newTags,
limit: querystring.getNumber("limit"),
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you don't need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to update the url while not reloading the page is it not the right way ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see what you were trying to do. I'd avoid using the querystring for this - it doesn't make sense for the add post page to manipulate the querystring like this. Can you change this to use the same cache that the title and description is being stored in - you can save a CSV string of the tag ids that are selected, that should work well I think.

Copy link
Contributor

@mattwoberts mattwoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's coming on..

@mattwoberts
Copy link
Contributor

Hi @MercierMateo , how's it all going? Are you waiting on me for anything?

@MercierMateo
Copy link
Contributor Author

I got busy and forgot about it sorry, thanks for reminding me i'll look back into it.

Is the way I did it OK UI wise ? I don't know if it fits in the design.

I will do the enable/disable part in the next days

@mattwoberts
Copy link
Contributor

Is the way I did it OK UI wise ? I don't know if it fits in the design.

The design is looking good, it just needs some spacing where the arrow is, go for the same size spacing that you have between the title and description...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants