-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create post with tags from the UI #1240
base: main
Are you sure you want to change the base?
Conversation
I achieved a first working version. I will look into making this optional through the configuration. |
navigator.replaceState( | ||
querystring.stringify({ | ||
view: querystring.get("view"), | ||
query: querystring.get("query"), | ||
tags: newTags, | ||
limit: querystring.getNumber("limit"), | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure you don't need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to update the url while not reloading the page is it not the right way ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you were trying to do. I'd avoid using the querystring for this - it doesn't make sense for the add post page to manipulate the querystring like this. Can you change this to use the same cache that the title and description is being stored in - you can save a CSV string of the tag ids that are selected, that should work well I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's coming on..
Hi @MercierMateo , how's it all going? Are you waiting on me for anything? |
I got busy and forgot about it sorry, thanks for reminding me i'll look back into it. Is the way I did it OK UI wise ? I don't know if it fits in the design. I will do the enable/disable part in the next days |
Issue: #1211
Follow up on this closed PR : #1221
Visitors can now create post with tags from the ui